Skip to content

gh-129020: Remove ambiguous sentence from tokenize.untokenize docs #129021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jan 19, 2025

The diff is larger but it simply removes The reconstructed script is returned as a single string. and re-wraps the paragraph.


📚 Documentation preview 📚: https://cpython-previews--129021.org.readthedocs.build/

@tomasr8 tomasr8 added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 19, 2025
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting review labels Jan 19, 2025
Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with it being misleading and unnecessary as it is explained in the next paragraph.

@AA-Turner AA-Turner merged commit bca35f0 into python:main Jan 20, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129035 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129036 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 20, 2025
AA-Turner pushed a commit that referenced this pull request Jan 20, 2025
…` docs (GH-129021) (#129035)

gh-129020: Remove ambiguous sentence from `tokenize.untokenize` docs (GH-129021)
(cherry picked from commit bca35f0)

Co-authored-by: Tomas R <[email protected]>
AA-Turner pushed a commit that referenced this pull request Jan 20, 2025
…` docs (GH-129021) (#129036)

gh-129020: Remove ambiguous sentence from `tokenize.untokenize` docs (GH-129021)
(cherry picked from commit bca35f0)

Co-authored-by: Tomas R <[email protected]>
@tomasr8 tomasr8 deleted the untok-docs branch January 20, 2025 08:24
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants