gh-71339: Use new assertion methods in tests

[serhiy-storchaka]

They provide better error report.

Only 1-2 lines are changed in the half of files, 3-4 lines in other quarter of files, and only in about 10 files there are more than 10 changed lines. So all this have been united in a single PR.

• Issue: Additional assert methods for unittest #71339

[picnixz]

Not sure if it's me or not, but having that many files to review makes my GH interface crash (or load very slowly). Would it be possible to split this PR, at least per folders? just so that 1) it reduces the number of review requests 2) it helps us to review if possible?

[serhiy-storchaka]

I have already already created 15 other PRs for groups of files with significant number of changes. But it is not worth to create a PR for 5 changed lines in 2 files.

[picnixz]

(Oh maybe I shouldn't have scheduled build bots if you had other commits... sorry in advance, though I can look at the buildbots status page)

[terryjreedy]

I was checking test_idle when I found this PR in my mailbox. (EDIT) 10 rather than just 2 idle tests can be changed and I want to backport them. I think it easiest if I make a separate PR (DONE, #129213) attached to the same issue I copied the 2 changes made here so there should be no conflict.

EDIT The IDLE changes are merged and backported.

[terryjreedy]

I non-recursively searched self.assert.*(issubclass|hasattr|startswith|endswith) inF:\dev\3x\Lib\test\test_t*.py (with IDLE) and found the same change candidates in the test_t*.py files included here (and only a couple of false positives). The replacements all looked right.

This is the 1 AMD64 Android failure.

======================================================================
FAIL: testAssertHasAttr (test.test_unittest.test_case.Test_TestCase.testAssertHasAttr)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_unittest/test_case.py", line 803, in testAssertHasAttr
    with self.assertRaises(self.failureException) as cm:
         ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: AssertionError not raised

[serhiy-storchaka]

The patch was initially created in 2016. It was then updated few years later, and just before creating this PR. Since the IDLE tests are located outside of the Lib/test tree, I missed new tests there.

[mhsmith]

!buildbot ios

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit cc1f37a 🤖

The command will test the builders whose names match following regular expression: ios

The builders matched are:

• iOS ARM64 Simulator PR

[mhsmith]

!buildbot android

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit cc1f37a 🤖

The command will test the builders whose names match following regular expression: android

The builders matched are:

• aarch64 Android PR
• AMD64 Android PR

[mhsmith]

!buildbot android

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit cc1f37a 🤖

The command will test the builders whose names match following regular expression: android

The builders matched are:

• AMD64 Android PR
• aarch64 Android PR

[mhsmith]

Not sure what happened before with Android and iOS, but they both seem fine now.

[serhiy-storchaka]

It was an issue in different tests which was fixed by #129133.

No need to trigger buildbots. This PR is not emergent. It will be merged after merging all related PRs. Some changes can be extracted into separate PRs (like IDLE's).

[serhiy-storchaka]

There have been practically no conflicts in the last few months. This means that this PR affects a very small part of the code that is actively changing. So I plan to merge this PR without backporting to 3.13. Probability of conflicts in future backports to 3.13 is low.

[miss-islington-app]

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[bedevere-app]

GH-134498 is a backport of this pull request to the 3.14 branch.