Skip to content

GH-92897: schedule the check_home deprecation to 3.15 #129102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

GH-92897: schedule the check_home deprecation to 3.15 #129102

merged 1 commit into from
Jan 20, 2025

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Jan 20, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 20, 2025
Closed
@FFY00 FFY00 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed awaiting core review labels Jan 20, 2025
@FFY00 FFY00 enabled auto-merge (squash) January 20, 2025 21:17
@FFY00 FFY00 merged commit e52ab56 into python:main Jan 20, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @FFY00 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @FFY00, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e52ab564da84540a7544cb829f262b0154efccae 3.13

@miss-islington-app
Copy link

Sorry, @FFY00, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e52ab564da84540a7544cb829f262b0154efccae 3.12

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@FFY00 @srinivasreddy
pythonGH-92897: schedule the check_home deprecation to 3.15 (python#1…
4f6a7f6 
…29102)
@terryjreedy
Copy link
Member

If you decided not to backport, please remove labels.

hugovk pushed a commit to hugovk/cpython that referenced this pull request Feb 26, 2025
@FFY00 @hugovk
[3.13] pythonGH-92897: schedule the check_home deprecation to 3.15 (p…
3850b51 
…ythonGH-129102)

(cherry picked from commit e52ab56)

Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2025

GH-130583 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 26, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request Feb 26, 2025
@FFY00 @hugovk
[3.12] pythonGH-92897: schedule the check_home deprecation to 3.15 (p…
19dfe00 
…ythonGH-129102)

(cherry picked from commit e52ab56)

Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2025

GH-130585 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 26, 2025
hugovk
hugovk reviewed Feb 26, 2025
View reviewed changes
Doc/deprecations/pending-removal-in-3.15.rst
Comment on lines +56 to +57
* The ``check_home`` argument of :func:`sysconfig.is_python_build` has been
deprecated since Python 3.12.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the old deprecation from "Pending removal in future versions":

cpython/Doc/deprecations/pending-removal-in-future.rst

Lines 114 to 115 in 56e1900

* :func:`sysconfig.is_python_build` *check_home* parameter is deprecated and
ignored.

I'll open a new PR to remove it from main, and include it in the backports of this PR.

@hugovk hugovk mentioned this pull request Feb 26, 2025
Merged
FFY00 added a commit that referenced this pull request Feb 27, 2025
@hugovk @FFY00
[3.13] GH-92897: schedule the check_home deprecation to 3.15 (GH-129102…
4100fb0 
…) (#130583)

Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
FFY00 added a commit that referenced this pull request Feb 27, 2025
@hugovk @FFY00
[3.12] GH-92897: schedule the check_home deprecation to 3.15 (GH-129102…
a55a9cd 
…) (#130585)

Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

Assignees

@FFY00 FFY00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FFY00 @terryjreedy @hugovk