Skip to content

gh-119182: Use public PyUnicodeWriter in _json.c #129249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 23, 2025

Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API.

Replace the private _PyUnicodeWriter API with the public
PyUnicodeWriter API.
Copy link
Contributor

@cmaloney cmaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a plan for _PyUnicodeWriter_IsEmpty?

@vstinner
Copy link
Member Author

Have a plan for _PyUnicodeWriter_IsEmpty?

My plan is to leave it in _json.c for now :-) I would prefer to not make it public, unless more people ask for such feature.

Also, the function can be removed and replaced with an empty variable. I just tried to minimize changes in my PR.

@vstinner vstinner merged commit 6e63c47 into python:main Jan 24, 2025
44 checks passed
@vstinner vstinner deleted the json_writer branch January 24, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants