Skip to content

[WIP] gh-129354: Use PyErr_FormatUnraisable() function #129359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] gh-129354: Use PyErr_FormatUnraisable() function #129359

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 27, 2025 •
edited by bedevere-app bot
Loading

Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable().

@vstinner
pythongh-129354: Use PyErr_FormatUnraisable() function
8e8167d 
Replace PyErr_WriteUnraisable() with PyErr_FormatUnraisable().
@bedevere-app bedevere-app bot mentioned this pull request Jan 27, 2025
Closed
@vstinner
Copy link
Member Author

This PR is now written to be merged as it is. It's only to show only #129354 can look alike.

If the approach is validated, I will split the PR into small chunks.

@vstinner
Copy link
Member Author

I started to split this PR into smaller PRs: #129435.

@vstinner
Copy link
Member Author

vstinner commented Feb 1, 2025 •
edited
Loading

I have split this giant PR into smaller PRs. See PRs attached to the issue. I close this PR.

@vstinner vstinner closed this Feb 1, 2025
@vstinner vstinner deleted the format_unraisable branch February 1, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 will be requested when the pull request is marked ready for review kumaraditya303 is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag will be requested when the pull request is marked ready for review berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle will be requested when the pull request is marked ready for review pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin will be requested when the pull request is marked ready for review abalkin is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead will be requested when the pull request is marked ready for review gpshead is a code owner

@picnixz picnixz Awaiting requested review from picnixz picnixz will be requested when the pull request is marked ready for review picnixz is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel will be requested when the pull request is marked ready for review iritkatriel is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@methane methane Awaiting requested review from methane methane will be requested when the pull request is marked ready for review methane is a code owner

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher will be requested when the pull request is marked ready for review brandtbucher is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski will be requested when the pull request is marked ready for review savannahostrowski is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 will be requested when the pull request is marked ready for review 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc will be requested when the pull request is marked ready for review willingc is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vstinner