Skip to content

gh-129874: avoid mixing pure python and C implementation of asyncio #129875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

gh-129874: avoid mixing pure python and C implementation of asyncio #129875

merged 1 commit into from
Feb 9, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Feb 9, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 9, 2025
Closed
@kumaraditya303 kumaraditya303 requested a review from ambv February 9, 2025 05:28
asvetlov
asvetlov approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, thanks for the PR.
The test suite has separate tests for making sure that _register_task and family work as expected.
Pure task implementation could use pure task registering API, sure.

@kumaraditya303 kumaraditya303 merged commit d5796e6 into python:main Feb 9, 2025
46 checks passed
@kumaraditya303 kumaraditya303 deleted the pure branch February 9, 2025 10:27
@kumaraditya303 kumaraditya303 mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @asvetlov