Skip to content

gh-129870: Skip test_dump_virtual_tables if SQLite lacks FTS4 support #129913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

gh-129870: Skip test_dump_virtual_tables if SQLite lacks FTS4 support #129913

merged 1 commit into from
Feb 9, 2025

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 9, 2025 •
edited by bedevere-app bot
Loading

@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 9, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 9, 2025
Closed
@erlend-aasland
Copy link
Contributor Author

cc. @picnixz & @fazalmajid.

@erlend-aasland erlend-aasland merged commit cda83ca into python:main Feb 9, 2025
50 checks passed
@erlend-aasland erlend-aasland deleted the sqlite/test-dump-virtual-tables branch February 9, 2025 20:43
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 9, 2025
@erlend-aasland @miss-islington
pythongh-129870: Skip test_dump_virtual_tables if SQLite lacks FTS4 s…
020ee5b 
…upport (pythonGH-129913)

(cherry picked from commit cda83ca)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 9, 2025

GH-129918 is a backport of this pull request to the 3.13 branch.

@miss-islington-app

This comment was marked as outdated.

Sign in to view
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 9, 2025
@erlend-aasland erlend-aasland removed the needs backport to 3.12 only security fixes label Feb 9, 2025
@erlend-aasland
Copy link
Contributor Author

The patch won't apply cleanly to 3.12, and I don't think it is worth the hassle to manually backport it.

@picnixz
Copy link
Member

picnixz commented Feb 9, 2025

3.12 is almost EOL for bug fixes, but maybe for downstream distributions it could be worth it? if you need, I can take care of it tomorrow (and I can check if the backport is really annoying or not). Otherwise, we can probably not backport it (strictly speaking, I'm actually surprised by this as I couldn't find anything about this in the changelog, although sqlite3 recently changed multiple things in their configure/makefile script).

erlend-aasland added a commit that referenced this pull request Feb 9, 2025
@miss-islington @erlend-aasland
[3.13] gh-129870: Skip test_dump_virtual_tables if SQLite lacks FTS4 …
d26c2fe 
…support (GH-129913) (#129918)

(cherry picked from commit cda83ca)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
Copy link
Contributor Author

I don't think any distros shipping 3.12 will encounter this issue, given that FTS5 is a breaking change from FTS4.

@erlend-aasland
Copy link
Contributor Author

But, if we want to backport this to 3.12, we can probably put the decorator in test_dbapi.py, where the test helpers originally were collected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@erlend-aasland erlend-aasland

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlend-aasland @picnixz