Skip to content

gh-68400: Remove outdated 2.7 comment #129919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

gh-68400: Remove outdated 2.7 comment #129919

merged 1 commit into from
Feb 10, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Feb 9, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 9, 2025
Closed
@terryjreedy
Copy link
Member

terryjreedy commented Feb 10, 2025 •
edited
Loading

Thread sanitizer 2nd failure is

File "/home/runner/work/cpython/cpython/Lib/test/test_abc.py", line 337, in test_registration_builtins
   self.assertIsInstance(42, A)
   ~~~~~~~~~~~~~~~~~~~~~^^^^^^^
AssertionError: 42 is not an instance of <class 'test.test_abc.test_factory.<locals>.TestABC.test_registration_builtins.<locals>.A'>

Rerunning just failures again. EDIT: third time worked.

@terryjreedy terryjreedy added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes topic-IDLE labels Feb 10, 2025
@terryjreedy terryjreedy merged commit d9bf3c1 into python:main Feb 10, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2025
@StanFromIreland @miss-islington
pythongh-68400: Remove outdated 2.7 comment (pythonGH-129919)
9b76988 
(cherry picked from commit d9bf3c1)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 10, 2025

GH-129937 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2025
@StanFromIreland @miss-islington
pythongh-68400: Remove outdated 2.7 comment (pythonGH-129919)
f1930ea 
(cherry picked from commit d9bf3c1)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 10, 2025

GH-129938 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 10, 2025
terryjreedy pushed a commit that referenced this pull request Feb 10, 2025
@miss-islington @StanFromIreland
[3.12] gh-68400: Remove outdated 2.7 comment (GH-129919) (#129938)
7744588 
(cherry picked from commit d9bf3c1)

Co-authored-by: Stan Ulbrych <[email protected]>
terryjreedy pushed a commit that referenced this pull request Feb 10, 2025
@miss-islington @StanFromIreland
[3.13] gh-68400: Remove outdated 2.7 comment (GH-129919) (#129937)
dee4f2c 
(cherry picked from commit d9bf3c1)

Co-authored-by: Stan Ulbrych <[email protected]>
@python python deleted a comment from bedevere-bot Feb 10, 2025
@terryjreedy
Copy link
Member

Both backports merged. Done.

@StanFromIreland StanFromIreland deleted the patch-14 branch February 10, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees
No one assigned
Labels
skip news topic-IDLE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @terryjreedy @picnixz