Skip to content

[3.11] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (#122566) #130260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 18, 2025

(cherry picked from commit fc233f4)

The ubuntu-20.04 image is deprecated and will be fully unsupported by 2025-04-01: actions/runner-images#11101.

Plus some other things like quotes and zizmor fixes from main.

@hugovk hugovk marked this pull request as draft February 18, 2025 13:28
@hugovk
Copy link
Member Author

hugovk commented Feb 18, 2025

Let's go through these one-by-one. ABI check first, python3.11 has changed when using ubuntu-22.04 instead of ubuntu-20.04. I'll add the changed file here, and include the RM when the PR is ready for merge.

https://devguide.python.org/getting-started/setup-building/index.html#regenerate-the-abi-dump

@hugovk hugovk closed this Feb 18, 2025
@hugovk hugovk reopened this Feb 18, 2025
@hugovk
Copy link
Member Author

hugovk commented Feb 18, 2025

With ubuntu-24.04, "Ubuntu / build and test (ubuntu-24.04)" and "Address sanitizer" fail with:

The necessary bits to build these optional modules were not found:
nis                                                            
To find the necessary bits, look in setup.py in detect_modules() for the module's name.

But they pass with ubuntu-22.04 so it's enough to get them off ubuntu-20.04.

@hugovk hugovk marked this pull request as ready for review February 18, 2025 14:32
@hugovk hugovk requested a review from ezio-melotti February 18, 2025 14:32
@hugovk
Copy link
Member Author

hugovk commented Feb 18, 2025

@pablogsal We need to upgrade the CI away from ubuntu-20.04 because it's going away soon: actions/runner-images#11101. The change of OS version means we get a new ABI file, so pinging you on this.

@hugovk hugovk requested a review from pablogsal February 18, 2025 14:34
@@ -87,11 +87,13 @@ jobs:

check_abi:
name: 'Check if the ABI has changed'
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04 # 24.04 causes spurious errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if these are the same errors that we just saw about the missing bits?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, the comment was added in #126619 and the logs have since expired: https://github.com/python/cpython/actions/runs/11853955712/job/33035153091?pr=126619.

@pablogsal
Copy link
Member

@pablogsal We need to upgrade the CI away from ubuntu-20.04 because it's going away soon: actions/runner-images#11101. The change of OS version means we get a new ABI file, so pinging you on this.

Makes sense thanks a lot for the fix!

@pablogsal pablogsal merged commit b2c3a95 into python:3.11 Feb 18, 2025
28 checks passed
@hugovk hugovk deleted the backport-fc233f4-3.11 branch February 19, 2025 06:34
@ambv ambv changed the title [3.11] gh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (#122566) [3.11] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (#122566) Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants