Skip to content

[3.13] gh-116742: Fix subprocess test_check_output_timeout() (GH-130836) #130873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 5, 2025

Fix a race condition in test_check_output_timeout() of
test_subprocess. Don't write into stdout anymore, since there is no
reliable way to synchronize the parent and the child processes.

Change the timeout from 3 seconds to 0.1 seconds, and remove
@requires_resource('walltime') decorator.
(cherry picked from commit 67a942d)

Co-authored-by: Victor Stinner [email protected]

…-130836)

Fix a race condition in test_check_output_timeout() of
test_subprocess. Don't write into stdout anymore, since there is no
reliable way to synchronize the parent and the child processes.

Change the timeout from 3 seconds to 0.1 seconds, and remove
@requires_resource('walltime') decorator.
(cherry picked from commit 67a942d)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington miss-islington requested a review from gpshead as a code owner March 5, 2025 10:51
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Mar 5, 2025
@vstinner vstinner merged commit aa2c4e4 into python:3.13 Mar 5, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants