Skip to content

Update links from typing.readthedocs.io to typing.python.org #130877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Mar 5, 2025

@srittau
Copy link
Contributor Author

srittau commented Mar 5, 2025

I think this should be backported to all active python versions, if possible.

@srittau srittau mentioned this pull request Mar 5, 2025
4 tasks
@ZeroIntensity ZeroIntensity added skip issue needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 5, 2025
@ZeroIntensity
Copy link
Member

active python versions, if possible.

Active as in, security-only too? I'm don't think that will go over well.

@srittau
Copy link
Contributor Author

srittau commented Mar 5, 2025

It's not really that important as the links are redirected anyway, but I think the documentation should point to the canonical URL if possible.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do it for the bugfix versions (3.12 and up). 3.13 is the most important because that's what's found at https://docs.python.org.

Thank you for the PR and for getting the subdomain sorted!

@hugovk hugovk merged commit 4f62189 into python:main Mar 5, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 5, 2025
@miss-islington-app
Copy link

Thanks @srittau for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2025

GH-130883 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 5, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2025

GH-130884 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 5, 2025
@srittau srittau deleted the typing.python.org branch March 5, 2025 15:29
hugovk pushed a commit that referenced this pull request Mar 5, 2025
…H-130877) (#130883)

Update links from typing.readthedocs.io to typing.python.org (GH-130877)
(cherry picked from commit 4f62189)

Co-authored-by: Sebastian Rittau <[email protected]>
hugovk pushed a commit that referenced this pull request Mar 5, 2025
…H-130877) (#130884)

Update links from typing.readthedocs.io to typing.python.org (GH-130877)
(cherry picked from commit 4f62189)

Co-authored-by: Sebastian Rittau <[email protected]>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants