Skip to content

gh-111178: Change Argument Clinic signature for @classmethod #131157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 12, 2025

Use "PyObject*", instead of "PyTypeObject*", for @classmethod functions to fix an undefined behavior.

Use "PyObject*", instead of "PyTypeObject*", for @classmethod
functions to fix an undefined behavior.
@picnixz
Copy link
Member

picnixz commented Mar 12, 2025

@vstinner I would advise rewriting the commit and use `@classmethod` so that github does not automatically mention them

@vstinner vstinner changed the title gh-111178: Change Argument Clinic signature for @classmethod gh-111178: Change Argument Clinic signature for @classmethod Mar 12, 2025
@vstinner vstinner merged commit 061da44 into python:main Mar 12, 2025
49 checks passed
@vstinner vstinner deleted the clinic_self branch March 12, 2025 16:42
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 12, 2025
…python#131157)

Use "PyObject*", instead of "void*", for `@staticmethod` functions to
fix an undefined behavior.
vstinner added a commit that referenced this pull request Mar 13, 2025
) (#131159)

Use "PyObject*", instead of "void*", for `@staticmethod` functions to
fix an undefined behavior.
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
…ython#131157)

Use "PyObject*", instead of "PyTypeObject*", for `@classmethod`
functions to fix an undefined behavior.
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
…python#131157) (python#131159)

Use "PyObject*", instead of "void*", for `@staticmethod` functions to
fix an undefined behavior.
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…ython#131157)

Use "PyObject*", instead of "PyTypeObject*", for `@classmethod`
functions to fix an undefined behavior.
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…python#131157) (python#131159)

Use "PyObject*", instead of "void*", for `@staticmethod` functions to
fix an undefined behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants