gh-131507: Add support for syntax highlighting in PyREPL #131562
+217
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ambv
commented
Mar 21, 2025
•
ambv
commented
- Issue: Syntax highlighting in PyREPL #131507
Wulian233
reviewed
Mar 22, 2025
| @@ -2,12 +2,56 @@ | |||
| import unicodedata | |||
| import functools | |||
|
|
|||
| from idlelib import colorizer | |||
There was a problem hiding this comment.
from idlelib import colorizerOn Windows, if you do not choose to install Tcl/Tk, IDLE will not be available
See https://github.com/python/cpython/blob/main/Tools%2Fmsi%2Ftcltk%2Ftcltk.wixproj
| @@ -2,12 +2,56 @@ | |||
| import unicodedata | |||
| import functools | |||
|
|
|||
| from idlelib import colorizer | |||
| from typing import cast, Iterator, Literal, Match, NamedTuple, Pattern, Self | |||
There was a problem hiding this comment.
Here are some deprecated aliases. Although there are no issues at present, it would be better to switch to collection.abc
https://docs.python.org/3.14/library/typing.html#typing.Iterator
Viicos
reviewed
Mar 22, 2025
Comment on lines
+20
to
+27
| type ColorTag = ( | ||
| Literal["KEYWORD"] | ||
| | Literal["BUILTIN"] | ||
| | Literal["COMMENT"] | ||
| | Literal["STRING"] | ||
| | Literal["DEFINITION"] | ||
| | Literal["SYNC"] | ||
| ) |
There was a problem hiding this comment.
Suggested change
| type ColorTag = ( | |
| Literal["KEYWORD"] | |
| | Literal["BUILTIN"] | |
| | Literal["COMMENT"] | |
| | Literal["STRING"] | |
| | Literal["DEFINITION"] | |
| | Literal["SYNC"] | |
| ) | |
| type ColorTag = Literal["KEYWORD", "BUILTIN", "COMMENT", "STRING", "DEFINITION", "SYNC"] |
ambv
force-pushed
the
pyrepl-syntax-highlighting
branch
from
f4bd10f to
75cd06d
Compare
|
Here's what it looks like with the default Ubuntu dark/light themes: 
The contrast of the blue color seems a bit too low for the dark theme (I had the same issue in #132126). Maybe the 'intense' variant might look better? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.