Skip to content

gh-132042: Try to optimize class creation #132156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+164 −71
Open

gh-132042: Try to optimize class creation #132156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
56d13fc
Prebuild mro_dict for find_name_in_mro
sergey-miryanov Apr 6, 2025
1eed75d
Preget tp_dict
sergey-miryanov Apr 6, 2025
bba66d6
Slotdefs cache
sergey-miryanov Apr 7, 2025
bac95a5
Move slotdefs_cache to interp
sergey-miryanov Apr 8, 2025
8d1f5be
Use bytes for slotdefs_cache
sergey-miryanov Apr 8, 2025
8cf19e8
Use type_slots_ptrs cache
sergey-miryanov Apr 8, 2025
b0ad875
Move slotdefs_cache init to pycore_init_builtins
sergey-miryanov Apr 8, 2025
79a165d
Create slotdefs_cache only for main interpreter
sergey-miryanov Apr 9, 2025
a853294
Do not iterate slotdefs_cache just check dups count
sergey-miryanov Apr 9, 2025
75c17fb
Add name_count to pytype_slotdef and get rid of slotdefs_cache and re…
sergey-miryanov Apr 9, 2025
fc17a68
Rename _PyType_InitSlotDefsCache to _PyType_InitSlotDefsNameCounts
sergey-miryanov Apr 9, 2025
736bca4
Get rid of type_slots_ptrs and type_slots_pname from _Py_interp_cache…
sergey-miryanov Apr 9, 2025
1341ed9
Add news entry
sergey-miryanov Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Include/cpython/descrobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ struct wrapperbase {
const char *doc;
int flags;
PyObject *name_strobj;
uint8_t name_count;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining the purpose of this member and how it's computed. You can mention _PyType_InitSlotDefsNameCounts().

};

/* Flags for above struct */
Expand Down
2 changes: 0 additions & 2 deletions Include/internal/pycore_interp_structs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,8 +666,6 @@ struct _Py_interp_cached_objects {

/* object.__reduce__ */
PyObject *objreduce;
PyObject *type_slots_pname;
pytype_slotdef *type_slots_ptrs[MAX_EQUIV];

/* TypeVar and related types */
PyTypeObject *generic_type;
Expand Down
3 changes: 3 additions & 0 deletions Include/internal/pycore_typeobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ typedef int (*_py_validate_type)(PyTypeObject *);
extern int _PyType_Validate(PyTypeObject *ty, _py_validate_type validate, unsigned int *tp_version);
extern int _PyType_CacheGetItemForSpecialization(PyHeapTypeObject *ht, PyObject *descriptor, uint32_t tp_version);

// Precalculates count of non-unique slots
extern int _PyType_InitSlotDefsNameCounts(PyInterpreterState *interp);

#ifdef __cplusplus
}
#endif
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-04-10-01-52-42.gh-issue-132042.fePwlj.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve class creation times by up to 40%. Patch by Sergey Miryanov.
Loading
Loading