Skip to content

gh-131884: Fix incorrect formatting in json.dumps() when using indent and skipkeys=True #132200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-131884: Fix incorrect formatting in json.dumps() when using indent and skipkeys=True #132200

wants to merge 4 commits into from
+20 −7

Conversation

roeibenartzi
Copy link

@roeibenartzi roeibenartzi commented Apr 7, 2025 •
edited by bedevere-app bot
Loading

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 7, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Apr 7, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Apr 7, 2025
Open
nineteendo
nineteendo approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@nineteendo nineteendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this matches what I did in jsonyx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nineteendo nineteendo nineteendo approved these changes

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roeibenartzi @nineteendo