gh-130197: Test various encodings with pygettext #132244
Open
+226
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context: #131902 (comment)
We currently set the charset of the POT file as the default encoding on the system (
fp.encoding
):cpython/Tools/i18n/pygettext.py
Lines 574 to 576 in f5639d8
To have reproducible tests regardless of the OS they are running on, we set
-X utf8
in the tests. As a consequence, the POT charset is always set toutf-8
. I don't think there's an easy way to control that if we want to test other output encodings.. At least with these tests we know that non-utf8 input files can be read correctly.cc @serhiy-storchaka Let me know if this is what you had in mind for the tests!