-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-132399: ensure correct alignment of PyInterpreterState
when UBSan is on
#132428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-132399: ensure correct alignment of PyInterpreterState
when UBSan is on
#132428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Might be worth running the buildbots just to make sure there are no weird issues with _Alignof()
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 12032df 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132428%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Hopefully not because I don't know the alternative (it's also something that was only standardized in C11 IIRC but I hope that we won't have issues) |
The Fedora failures are unrelated I think as they already appeared previously. |
|
|
With that PR, the test suite passes for the free-threaded build with UBSan:
There is still one UB failure (fixed by #131605) but this is not specific to free-threading.
cc @colesbury
-fsanitize=undefined -fno-sanitize-recover
on free-threaded build #132399