GH-133372: C implementation of types._GeneratorWrapper is added. #133373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
requested changes
May 4, 2025
| Py_CLEAR(gw->gw_gen); | ||
| Py_CLEAR(gw->gw_name); | ||
| Py_CLEAR(gw->gw_qualname); | ||
| if (gw->gw_weakreflist != NULL) |
There was a problem hiding this comment.
Per PEP 7, all if clauses are supposed to have braces.
| "__name__ must be set to a string object"); | ||
| return -1; | ||
| } | ||
| Py_XSETREF(gw->gw_name, Py_NewRef(value)); |
There was a problem hiding this comment.
We need a critical section if we're going to modify this in methods.
There was a problem hiding this comment.
Could you please give me some additional context on it?
I've just copied this code from gen_set_name function.
Does this mean that critical section is also needed in that func?
There was a problem hiding this comment.
|
I close this because of #134563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.