gh-133886: Fix sys.remote_exec() for non-UTF-8 paths #133887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now supports non-ASCII paths in non-UTF-8 locales and non-UTF-8 paths in UTF-8 locales.
serhiy-storchaka
force-pushed
the
sys-remote_exec-non-utf8
branch
from
45e4604 to
bd30460
Compare
pablogsal
reviewed
May 12, 2025
| run_remote_debugger_script(path); | ||
| PyObject *path_obj = PyUnicode_DecodeFSDefault(path); | ||
| if (path_obj == NULL) { | ||
| PyErr_FormatUnraisable("Can't decode debugger script"); |
There was a problem hiding this comment.
Can we include the script path in this exception ?
pablogsal
reviewed
May 12, 2025
| 'undecodable paths are not supported on macOS') | ||
| def test_remote_exec_undecodable(self): | ||
| script = 'print("Remote script executed successfully!")' | ||
| script_path = os_helper.TESTFN_UNDECODABLE + b'_undecodable_remote.py' |
There was a problem hiding this comment.
Oh nice! I didn't know about this
Python/sysmodule.c
Outdated
| } | ||
| Py_DECREF(path); |
There was a problem hiding this comment.
Maybe we can have a goto label for the error at this stage. I don't mind either way so up to you
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 13, 2025
…133887) It now supports non-ASCII paths in non-UTF-8 locales and non-UTF-8 paths in UTF-8 locales. (cherry picked from commit c09cec5) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-133963 is a backport of this pull request to the 3.14 branch. |
|
Thank you for your review, @pablogsal. |
|
We could also use natural UTF-16 for paths on Windows, but this is more significant change. |
serhiy-storchaka
added a commit
that referenced
this pull request
May 13, 2025
… (GH-133963) It now supports non-ASCII paths in non-UTF-8 locales and non-UTF-8 paths in UTF-8 locales. (cherry picked from commit c09cec5) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now supports non-ASCII paths in non-UTF-8 locales and non-UTF-8 paths in UTF-8 locales.