Skip to content

gh-133904: math.factorial documentation fix #133907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2025
Merged

gh-133904: math.factorial documentation fix #133907

merged 6 commits into from
May 12, 2025

Conversation

mkaraev
Copy link
Contributor

@mkaraev mkaraev commented May 11, 2025 •
edited by ZeroIntensity
Loading

@python-cla-bot
Copy link

python-cla-bot bot commented May 11, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels May 11, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 11, 2025
@mkaraev mkaraev changed the title math.factorial documentation fix gh-133904: math.factorial documentation fix May 11, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 11, 2025
Closed
@mkaraev
Copy link
Contributor Author

mkaraev commented May 11, 2025 •
edited
Loading

@sobolevn @picnixz @skirpichev can you please review?

skirpichev
skirpichev reviewed May 11, 2025
View reviewed changes
@skirpichev skirpichev mentioned this pull request May 12, 2025
Closed
@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 12, 2025
skirpichev
skirpichev reviewed May 12, 2025
View reviewed changes
sobolevn
sobolevn reviewed May 12, 2025
View reviewed changes
@skirpichev skirpichev requested a review from sobolevn May 12, 2025 07:43
@mkaraev
Copy link
Contributor Author

mkaraev commented May 12, 2025 •
edited
Loading

@skirpichev you added two labels about back-porting to python 3.13 and 3.14. Do I need to make similar changes to that branches too?

@skirpichev
Copy link
Member

you added two labels about back-porting to python 3.13 and 3.14. Do I need to make similar changes to that branches too?

No, I think the witch will do her job this time.

sobolevn
sobolevn approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn enabled auto-merge (squash) May 12, 2025 09:06
@sobolevn
Copy link
Member

Congrats on your first CPython PR 🎉

skirpichev
skirpichev reviewed May 12, 2025
View reviewed changes
@sobolevn sobolevn disabled auto-merge May 12, 2025 09:13
sobolevn
sobolevn reviewed May 12, 2025
View reviewed changes
@sobolevn sobolevn enabled auto-merge (squash) May 12, 2025 09:14
@sobolevn sobolevn merged commit 27ed645 into python:main May 12, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 12, 2025
@miss-islington-app
Copy link

Thanks @mkaraev for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@mkaraev @sobolevn @miss-islington
pythongh-133904: Fix math.factorial documentation (pythonGH-133907)
43d61f9 
(cherry picked from commit 27ed645)

Co-authored-by: mkaraev <[email protected]>
Co-authored-by: sobolevn <[email protected]>
@miss-islington-app
Copy link

Sorry, @mkaraev and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 27ed64575d34f04029ba1d353810f3db4f4f045b 3.13

@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

GH-133918 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@sobolevn
Copy link
Member

@mkaraev can you please do a manual backport to 3.13? follow instructions in #133907 (comment)

@mkaraev
Copy link
Contributor Author

mkaraev commented May 12, 2025

@sobolevn sure, will do

@mkaraev mkaraev mentioned this pull request May 12, 2025
Closed
@mkaraev
Copy link
Contributor Author

mkaraev commented May 12, 2025

@sobolevn I tried to cherry pick manually and got some strange error.
Opened issue python/cherry-picker#159
Maybe I'm doing something wrong.

@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

GH-133922 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 12, 2025
sobolevn added a commit that referenced this pull request May 12, 2025
@mkaraev @sobolevn
[3.13] gh-133904: Fix math.factorial documentation (GH-133907) (#13…
532acbd 
…3922)

* [3.13] gh-133904: Fix `math.factorial` documentation (GH-133907)
(cherry picked from commit 27ed645)

Co-authored-by: mkaraev <[email protected]>
Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this pull request May 12, 2025
@miss-islington @mkaraev @sobolevn
[3.14] gh-133904: Fix math.factorial documentation (GH-133907) (#13…
ecc12bf 
…3918)

gh-133904: Fix `math.factorial` documentation (GH-133907)
(cherry picked from commit 27ed645)

Co-authored-by: mkaraev <[email protected]>
Co-authored-by: sobolevn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees

@sobolevn sobolevn

Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaraev @skirpichev @sobolevn