gh-134168: http.server with HTTPS fails to bind IPv6 addresses and ignores --directory flag

[ggqlq]

I add a new HTTPSDualStackServer class(like 'DualStackServer') in _main function to handle IPv6 addresses and the --directory flag.

• Issue: http.server with HTTPS fails to bind IPv6 addresses #134168

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[picnixz]

And please add tests. I don't understand why --directory is being ignored in the first place.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[ggqlq]

And please add tests. I don't understand why --directory is being ignored in the first place.

Should we move the runtime tests from PR #132540 to this one?

[picnixz]

Oh I thought that the other PR was merged. NVM, i'll merge the other one so that you can extend the existing tests.

[picnixz]

Ok, because we have some failures on the build bots, I've reverted the runtime tests but kept the static tests. Since this fix requires serving real files to check whether it works or not, I'll just assume that it locally works and be happy with it (I mean, what could go wrong?) I'm still planning to fix the runtime tests so that we can have a good coverage but it won't be a priority.

[picnixz]

I couldn't reproduce the IPv6 issue because I have disabled IPv6 and I'm too lazy to re-enable it. However, I can confirm that this fixes the --directory issue. I can probably confirm though that I don't have the same error (I have an OSError, meaning that the call to self.socket.bind was still ok but my OS didn't want to serve IPv6, while your error was during the parsing of the arguments, so before).

[picnixz]

@ggqlq Can you manually confirm that IPv6 + SSL works, IPv6 + other directory works, IPv6 + SSL + other directory works. I confirmed with IPv4 o my side.

[ggqlq]

I think they can all work properly.

IPv6 + SSL

$ ./python -m http.server -b ::1 --tls-cert ~/ssl/localhost.crt --tls-key ~/ssl/localhost.key
Serving HTTPS on ::1 port 8000 (https://[::1]:8000/) ...

$ curl -k https://[::1]:8000
# ...
<ul>
<li><a href=".azure-pipelines/">.azure-pipelines/</a></li>
<li><a href=".coveragerc">.coveragerc</a></li>
# ...

IPv6 + other directory

tree ~/test
~/test
├── 1
├── 2
└── 3

1 directory, 3 files

$ ./python -m http.server -b ::1 -d ~/test
Serving HTTP on ::1 port 8000 (http://[::1]:8000/) ...

$ curl http://[::1]:8000
# ...
<ul>
<li><a href="1">1</a></li>
<li><a href="2">2</a></li>
<li><a href="3">3</a></li>
</ul>

IPv6 + SSL + other directory

$ ./python -m http.server -b ::1 -d ~/test --tls-cert ~/ssl/localhost.crt --tls-key ~/ssl/localhost.key
Serving HTTPS on ::1 port 8000 (https://[::1]:8000/) ...

$ curl -k https://[::1]:8000
# ...
<ul>
<li><a href="1">1</a></li>
<li><a href="2">2</a></li>
<li><a href="3">3</a></li>
</ul>

[picnixz]

Great!

[miss-islington-app]

Thanks @ggqlq for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @ggqlq and @picnixz, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2fd09b011031f3c00c342b44e02e2817010e507c 3.14

[picnixz]

I'll take care of the bp.

[ggqlq]

@picnixz Thank you!

[bedevere-app]

GH-134630 is a backport of this pull request to the 3.14 branch.