Skip to content

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task #134202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2025
Merged

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task #134202

merged 6 commits into from
May 22, 2025

Conversation

graingert
Copy link
Contributor

@graingert graingert commented May 19, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 19, 2025
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels May 19, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 19, 2025
graingert
graingert commented May 19, 2025
View reviewed changes
graingert
graingert commented May 19, 2025
View reviewed changes
graingert
graingert commented May 19, 2025
View reviewed changes
gvanrossum
gvanrossum reviewed May 20, 2025
View reviewed changes
@gvanrossum gvanrossum mentioned this pull request May 20, 2025
Merged
@graingert graingert marked this pull request as ready for review May 20, 2025 06:54
gvanrossum
gvanrossum reviewed May 20, 2025
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I'm uneasy with how name, context and eager_task arguments are presented.

@gvanrossum
Copy link
Member

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

@graingert
Copy link
Contributor Author

graingert commented May 20, 2025 •
edited
Loading

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

I thought we were happy with the docs on 3.13 now? So this won't need a backport

@gvanrossum
Copy link
Member

I thought we were happy with the docs on 3.13 now? So this won't need a backport

Agreed, not to 3.13. But this should be marked as backport to 3.14 right?

What do you think about my comment on the signature description?

@gvanrossum gvanrossum added the needs backport to 3.14 bugs and security fixes label May 20, 2025
gvanrossum
gvanrossum approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG then! I will merge and ensure a backport to 3.14 happens.

@gvanrossum gvanrossum changed the title gh-128307: update docs to TaskGroup.create_task and asyncio.create_task gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task May 22, 2025
@gvanrossum gvanrossum merged commit a3d0306 into python:main May 22, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 22, 2025
@miss-islington-app
Copy link

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2025
@graingert @miss-islington
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
cd5c579 
…e_task, asyncio.create_task (pythonGH-134202)

(cherry picked from commit a3d0306)

Co-authored-by: Thomas Grainger <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2025

GH-134553 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 22, 2025
kumaraditya303 pushed a commit that referenced this pull request May 23, 2025
@miss-islington @graingert
[3.14] gh-128307: Update docs for asyncio.create_task, TaskGroup.crea…
1cdbb33 
…te_task, asyncio.create_task (GH-134202) (#134553)

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task (GH-134202)
(cherry picked from commit a3d0306)

Co-authored-by: Thomas Grainger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graingert @gvanrossum @kumaraditya303