Skip to content

GH-130415: Use POP_TWO_LOAD_CONST_INLINE_BORROW #134241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

GH-130415: Use POP_TWO_LOAD_CONST_INLINE_BORROW #134241

wants to merge 5 commits into from

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented May 19, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 19, 2025
Open
17 tasks
@Fidget-Spinner
Copy link
Member

Thanks for the PR. I'd like to advocate for this PR #132733 which will simplify this PR quite a bit. All you'd have to do after that PR lands is to add pure to the current bytecode definition. Then if you want you can improve the cases generator to automatically insert the pops.

@savannahostrowski
Copy link
Member Author

Ah, I didn't know that work was happening. I'll add some tests and then add the annotations when your PR lands.

@Fidget-Spinner
Copy link
Member

Thanks! The tests are definitely still gonna be very useful :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savannahostrowski @Fidget-Spinner