Skip to content

gh-101100: Fix Sphinx warnings in library/decimal.rst #134303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

koyuki7w
Copy link
Contributor

@koyuki7w koyuki7w commented May 20, 2025

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 20, 2025
@hugovk
Copy link
Member

hugovk commented May 20, 2025

Oh one more thing, while we're editing this file, we have a mix of "Sentence case" and "Title Case" headers.

Please could you change "Quick-start Tutorial" and "Floating-Point Notes" to "Quick-start tutorial" and "Floating-point notes"?

(re: https://devguide.python.org/documentation/style-guide/#capitalization)

@vstinner
Copy link
Member

cc @skirpichev

@skirpichev skirpichev self-requested a review May 20, 2025 12:17
@hugovk hugovk merged commit f3acbb7 into python:main May 20, 2025
24 checks passed
@miss-islington-app
Copy link

Thanks @koyuki7w for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@miss-islington-app
Copy link

Sorry, @koyuki7w and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f3acbb72ff125172522545ec6f6c676f5108b109 3.13

@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

GH-134338 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request May 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

GH-134339 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2025
@hugovk hugovk changed the title gh-101100: Fix sphinx warnings in library/decimal.rst gh-101100: Fix Sphinx warnings in library/decimal.rst May 20, 2025
hugovk pushed a commit that referenced this pull request May 20, 2025
hugovk added a commit that referenced this pull request May 20, 2025
@koyuki7w koyuki7w deleted the doc-fix-2 branch May 20, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants