Skip to content

GH-133779: Fix Windows JIT builds #134349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented May 20, 2025

This updates the JIT build scripts to handle arbitrary pyconfig.h locations and build directories.

It's not super pretty, but it unblocks CI for the sprint until I have time go through and clean some of this stuff up.

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty enough to me. Not as bad as how the sysconfig->distutils->setuptools chain handles the same problem.

Don't forget to backport to 3.14.

@brandtbucher brandtbucher added the needs backport to 3.14 bugs and security fixes label May 20, 2025
@brandtbucher brandtbucher merged commit 7ad9046 into python:main May 20, 2025
77 checks passed
@miss-islington-app
Copy link

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

GH-134359 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build skip news sprint topic-JIT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants