-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-134323: Fix the new threading.RLock.locked
method
#134368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @sobolevn who added this locked() method.
Misc/NEWS.d/next/Library/2025-05-20-19-16-30.gh-issue-134323.ZQZGvw.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2025-05-20-19-16-30.gh-issue-134323.ZQZGvw.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Kumar Aditya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the multiple updates :-)
…H-134368) (cherry picked from commit 3effede) Co-authored-by: Duprat <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
GH-134510 is a backport of this pull request to the 3.14 branch. |
Merged, thanks for the fix. |
) (#134510) gh-134323: Fix the new `threading.RLock.locked` method (GH-134368) (cherry picked from commit 3effede) Co-authored-by: Duprat <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
Thank's all for your comments |
…134368) Co-authored-by: Kumar Aditya <[email protected]>
This method should call the private
locked
method of_block
attribute instead the private_count
attribute which is reserved for counting recursive call ofacquire/release
.The fix also concerns the
_thread
module in therlock_locked
function.threading.RLock.locked()
method fails #134323