gh-134451: Delete @dataclass for asyncio.tools.CycleFoundException class
#134513
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@sobolevn can you see, please? |
sobolevn
reviewed
May 22, 2025
Misc/NEWS.d/next/Library/2025-05-22-14-12-53.gh-issue-134451.M1rD-j.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: sobolevn <[email protected]>
kumaraditya303
approved these changes
May 23, 2025
No, dataclass was used to just avoid manually writing |
sobolevn
changed the title
asyncio.tools. CycleFoundException class@dataclass for asyncio.tools.CycleFoundException class
|
Thanks @RenameMe1 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2025
…ataclass to a regular exception type. (pythonGH-134513) (cherry picked from commit f9324cb) Co-authored-by: Evgeny Demchenko <[email protected]>
|
GH-134564 is a backport of this pull request to the 3.14 branch. |
sobolevn
approved these changes
May 23, 2025
|
Oh, never mind - these were just my small nitpicks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.