Skip to content

gh-134381: Improve thread safety in _PyThread_AfterFork by preserving not-started handles #134514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 23, 2025
Merged

gh-134381: Improve thread safety in _PyThread_AfterFork by preserving not-started handles #134514

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c20f566
Improve thread safety in _PyThread_AfterFork by preserving not-starte…
zangjiucheng May 22, 2025
c144379
📜🤖 Added by blurb_it.
blurb-it[bot] May 22, 2025
40da262
Add a test case, and improve the NEWS.d
zangjiucheng May 22, 2025
be1f512
Rearrage test location, skip fork test on windows
zangjiucheng May 22, 2025
9c8f303
Enhance comment message, recreate test scenario in _test_multiprocessing
zangjiucheng May 22, 2025
5e0158c
Enhance test case setup, skip if get_start_method() is not set to 'fork'
zangjiucheng May 23, 2025
ca06d61
Merge branch 'main' into gh-134381-main
zangjiucheng May 23, 2025
9827b43
Addressed formatting
zangjiucheng May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-05-22-14-48-19.gh-issue-134381.2BXhth.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve thread safety in :class:`_PyThread_AfterFork` by preserving not-started handles
5 changes: 5 additions & 0 deletions Modules/_threadmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,11 @@ _PyThread_AfterFork(struct _pythread_runtime_state *state)
continue;
}

// keep not_start handles – they are safe to start in the child
if (handle->state == THREAD_HANDLE_NOT_STARTED){
continue;
}

// Mark all threads as done. Any attempts to join or detach the
// underlying OS thread (if any) could crash. We are the only thread;
// it's safe to set this non-atomically.
Expand Down
Loading