Skip to content

bpo-37087: Adding native ID support for OpenBSD. #13654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Jun 3, 2019
Merged

bpo-37087: Adding native ID support for OpenBSD. #13654

merged 3 commits into from Jun 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2019

Following-up work started by bpo-36084.

https://bugs.python.org/issue37087

Following-up work started by bpo-36084.
@ghost ghost changed the title Adding native ID support for OpenBSD. bpo-37087: Adding native ID support for OpenBSD. May 29, 2019
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be new entry needed. and tests as well?

@ghost
Copy link
Author

ghost commented May 30, 2019

For the tests, it is using the common ones set previously by [bpo-36084](b121f63#diff-679617a57f98a01a0eda14b0f9fb03adR107).

@vstinner
Copy link
Member

vstinner commented Jun 2, 2019

You have to update the "availability" in the doc:
https://docs.python.org/dev/library/threading.html#threading.get_native_id

See the whole commit to see which doc should be updated:
b121f63

@@ -82,7 +82,7 @@ This module defines the following functions:
Its value may be used to uniquely identify this particular thread system-wide
(until the thread terminates, after which the value may be recycled by the OS).

.. availability:: Windows, FreeBSD, Linux, macOS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also have to update the attribute:
https://docs.python.org/dev/library/threading.html#threading.Thread.native_id

Hum, maybe the atttribute availability can be enhanced as ".. availability:: Required :func:get_native_id function." to avoid redundance.

@@ -355,7 +355,7 @@ since it is impossible to detect the termination of alien threads.
system-wide) from the time the thread is created until the thread
has been terminated.

.. availability:: Windows, FreeBSD, Linux, macOS.
.. availability:: Required :func:get_native_id function.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis CI failed here:

[library/threading:387] ":func" found in "Required :func:get_native_id function."
Suggested change
.. availability:: Required :func:get_native_id function.
.. availability:: Require :func:`get_native_id` function.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@vstinner
Copy link
Member

vstinner commented Jun 3, 2019

Thanks @dcarlier-afilias! Nice contribution.

I'm amazed by the diversity of implementations to get the "native thread identifier"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants