[WIP] bpo-36402: add random sleep to test_threads_join_2() #13889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add random short sleep of around 10 ms to test_threads_join_2() to reproduce https://bugs.python.org/issue36402 crash.
|
How long the test takes to run? I am asking because if it is low, we can run the test multiple times so it does not magically pass on the main CI and then fail somewhere else. Or is more or less reliable that will fail almost all the time? |
|
@pablogsal: Using this PR, the test is way more likely when run in a loop using: The CI only runs the test once and so was just lucky. You might tune my PR to make the crash more reliable, but I didn't bother to go that far ;-) |
|
I used this PR to debug https://bugs.python.org/issue36402 I merged my PR #13948 fix which also includes changes of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add random short sleep of around 10 ms to test_threads_join_2() to
reproduce https://bugs.python.org/issue36402 crash.
https://bugs.python.org/issue36402