Skip to content

bpo-37250: define tp_print for backwards compatibility #14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Include/cpython/object.h
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ typedef struct {
* backwards-compatibility */
typedef Py_ssize_t printfunc;

/* Define tp_print as alias of tp_vectorcall to allow for code accessing
* this field (hopefully not actually doing anything with it). */
#define tp_print tp_vectorcall

typedef struct _typeobject {
PyObject_VAR_HEAD
const char *tp_name; /* For printing, in format "<module>.<name>" */
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
``tp_print`` is defined as alias of ``tp_vectorcall`` to restore support for
old code (in particular generated by Cython) setting ``tp_print = 0``.
4 changes: 4 additions & 0 deletions Modules/_testcapimodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -6008,6 +6008,10 @@ PyInit__testcapi(void)
Py_INCREF(&MyList_Type);
PyModule_AddObject(m, "MyList", (PyObject *)&MyList_Type);

/* Old Cython code sets tp_print to 0, we check that
* this doesn't break anything. */
MyList_Type.tp_print = 0;

if (PyType_Ready(&MethodDescriptorBase_Type) < 0)
return NULL;
Py_INCREF(&MethodDescriptorBase_Type);
Expand Down