bpo-37328: remove deprecated HTMLParser.unescape #14186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is deprecated since Python 3.4
|
Oh! setuptools still depends on this, accidentally. |
|
pypa/setuptools#1788 is fixed. |
| @@ -9,7 +9,6 @@ | |||
|
|
|||
|
|
|||
| import re | |||
| import warnings | |||
| import _markupbase | |||
|
|
|||
| from html import unescape | |||
There was a problem hiding this comment.
I think this could be removed too if it's no longer needed (even though removing it might break some code if people are doing from html.parser import unescape instead of from html import unescape).
There was a problem hiding this comment.
unescape is used in this module several times.
|
#15483 bumps the setuptools version, so that'll unblock this once merged. |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
It is deprecated since Python 3.4.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
It is deprecated since Python 3.4.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
It is deprecated since Python 3.4.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is deprecated since Python 3.4
https://bugs.python.org/issue37328