bpo-37805: Add tests for json.dump(..., skipkeys=True) #15489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julian
reviewed
Aug 25, 2019
There was a problem hiding this comment.
Thanks!
(Not a core dev) but would probably be nice to keep this as a separate test method (e.g. test_dump_skipkeys ) -- the original test here is small and easily understood in isolation whereas this new one needs a bit more knowledge to follow.
Otherwise lgtm though for whatever that counts.
|
@Julian |
|
@methane Can you please take a look? |
epicfaace
approved these changes
Aug 25, 2019
methane
approved these changes
Aug 26, 2019
|
@corona10: Status check is done, and it's a success ✅ . |
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2019
https://bugs.python.org/issue37805 Automerge-Triggered-By: @methane (cherry picked from commit 44cd86b) Co-authored-by: Dong-hee Na <[email protected]>
|
GH-15507 is a backport of this pull request to the 3.8 branch. |
|
GH-15508 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2019
https://bugs.python.org/issue37805 Automerge-Triggered-By: @methane (cherry picked from commit 44cd86b) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 26, 2019
https://bugs.python.org/issue37805 Automerge-Triggered-By: @methane (cherry picked from commit 44cd86b) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 26, 2019
https://bugs.python.org/issue37805 Automerge-Triggered-By: @methane (cherry picked from commit 44cd86b) Co-authored-by: Dong-hee Na <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37805
Automerge-Triggered-By: @methane