bpo-38421: Update email.utils documentation #16678

Irishsmurf · 2019-10-09T13:36:38Z

Updates documentation around email.utils.parsedate_tz().

Currently, the documentation specifies that when a string without a is timezone passed to parsedate_tz(), the last tuple is returned as None.

This is no longer true since Python 3.3

https://bugs.python.org/issue38421

Automerge-Triggered-By: @encukou

Updates documentation around email.utils.parsedate_tz(). Currently, the documentation specifies that when a string without a is timezone passed to parsedate_tz(), the last tuple is returned as ```None```. This is no longer true since Python 3.4

the-knights-who-say-ni · 2019-10-09T13:36:41Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Irishsmurf

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

brandtbucher · 2019-10-09T21:05:43Z

Thanks for your time @Irishsmurf, and welcome to CPython!

I assume that you've seen the bot's message about the CLA?

brandtbucher

This looks like a good change to me!

willingc

Thanks @Irishsmurf for the contribution. This looks good to me.

@brandtbucher I will leave for the email team to review and merge. Thanks for triaging.

brandtbucher · 2019-10-23T17:05:39Z

Thanks for the review @willingc. One question I have, going forward:

This PR changes four words of documentation and can be verified as correct by either running or reading the source code. It also doesn't touch on the intricacies of email itself.

Do we typically still require email team review for this, or in general anything relating to email even a little bit? It's okay if they're the gatekeepers here, but otherwise I'm not sure if waiting is necessary...

encukou · 2019-11-05T15:56:10Z

Indeed, I'd rather merge this to all supported Python 3 versions, to let the email team handle more serious issues.
I plan to do that in a few weeks if there's no activity here.

miss-islington · 2019-11-12T12:38:47Z

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington · 2019-11-12T12:38:47Z

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington · 2019-11-12T12:38:49Z

Thanks @Irishsmurf for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington · 2019-11-12T12:38:50Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

bedevere-bot · 2019-11-12T12:39:06Z

GH-17121 is a backport of this pull request to the 3.7 branch.

Updates documentation around email.utils.parsedate_tz(). Currently, the documentation specifies that when a string without a is timezone passed to parsedate_tz(), the last tuple is returned as ```None```. This is no longer true since Python 3.3 https://bugs.python.org/issue38421 (cherry picked from commit a12255d) Co-authored-by: David K <[email protected]>

miss-islington · 2019-11-12T12:39:28Z

Thanks @Irishsmurf for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot · 2019-11-12T12:39:36Z

GH-17122 is a backport of this pull request to the 3.8 branch.

@encukou

Updates documentation around email.utils.parsedate_tz(). Currently, the documentation specifies that when a string without a is timezone passed to parsedate_tz(), the last tuple is returned as ```None```. This is no longer true since Python 3.3 https://bugs.python.org/issue38421 (cherry picked from commit a12255d) Co-authored-by: David K <[email protected]> https://bugs.python.org/issue38421 Automerge-Triggered-By: @encukou

@encukou

Updates documentation around email.utils.parsedate_tz(). Currently, the documentation specifies that when a string without a is timezone passed to parsedate_tz(), the last tuple is returned as ```None```. This is no longer true since Python 3.3 https://bugs.python.org/issue38421 (cherry picked from commit a12255d) Co-authored-by: David K <[email protected]> https://bugs.python.org/issue38421 Automerge-Triggered-By: @encukou

brandtbucher · 2019-11-12T15:57:51Z

Congrats on your first CPython contribution @Irishsmurf! 🍾

Looking forward to seeing more from you in the future.

Updates documentation around email.utils.parsedate_tz(). Currently, the documentation specifies that when a string without a is timezone passed to parsedate_tz(), the last tuple is returned as ```None```. This is no longer true since Python 3.3 https://bugs.python.org/issue38421

Update email.utils documentation

f596c56

Updates documentation around email.utils.parsedate_tz(). Currently, the documentation specifies that when a string without a is timezone passed to parsedate_tz(), the last tuple is returned as ```None```. This is no longer true since Python 3.4

Irishsmurf requested a review from a team as a code owner October 9, 2019 13:36

the-knights-who-say-ni added the CLA not signed label Oct 9, 2019

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 9, 2019

Update email.utils.rst

e2de236

brandtbucher added the skip news label Oct 9, 2019

brandtbucher approved these changes Oct 9, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Oct 9, 2019

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Oct 10, 2019

willingc approved these changes Oct 22, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Oct 22, 2019

encukou added 🤖 automerge labels Nov 12, 2019

miss-islington merged commit a12255d into python:master Nov 12, 2019

bedevere-bot removed the awaiting merge label Nov 12, 2019

bedevere-bot removed the needs backport to 3.7 label Nov 12, 2019

encukou added needs backport to 3.8 and removed needs backport to 3.8 labels Nov 12, 2019

bedevere-bot removed the needs backport to 3.8 label Nov 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-38421: Update email.utils documentation #16678

bpo-38421: Update email.utils documentation #16678

Irishsmurf commented Oct 9, 2019 •

edited by miss-islington

Loading

the-knights-who-say-ni commented Oct 9, 2019

brandtbucher commented Oct 9, 2019

brandtbucher left a comment

willingc left a comment

brandtbucher commented Oct 23, 2019

encukou commented Nov 5, 2019

miss-islington commented Nov 12, 2019

miss-islington commented Nov 12, 2019

miss-islington commented Nov 12, 2019

miss-islington commented Nov 12, 2019

bedevere-bot commented Nov 12, 2019

miss-islington commented Nov 12, 2019

bedevere-bot commented Nov 12, 2019

brandtbucher commented Nov 12, 2019

bpo-38421: Update email.utils documentation #16678

bpo-38421: Update email.utils documentation #16678

Conversation

Irishsmurf commented Oct 9, 2019 • edited by miss-islington Loading

the-knights-who-say-ni commented Oct 9, 2019

Recognized GitHub username

brandtbucher commented Oct 9, 2019

brandtbucher left a comment

Choose a reason for hiding this comment

willingc left a comment

Choose a reason for hiding this comment

brandtbucher commented Oct 23, 2019

encukou commented Nov 5, 2019

miss-islington commented Nov 12, 2019

miss-islington commented Nov 12, 2019

miss-islington commented Nov 12, 2019

miss-islington commented Nov 12, 2019

bedevere-bot commented Nov 12, 2019

miss-islington commented Nov 12, 2019

bedevere-bot commented Nov 12, 2019

brandtbucher commented Nov 12, 2019

Irishsmurf commented Oct 9, 2019 •

edited by miss-islington

Loading