Skip to content

[typo] fix quoted signature of setattrofunc #17251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

alexchandel
Copy link
Contributor

setattrofunc returns int, not PyObject *.

setattrofunc returns `int`, not `PyObject *`.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@alexchandel

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher
Copy link
Member

Thanks for your time @alexchandel, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! This looks good.

@alexchandel
Copy link
Contributor Author

Thank you @brandtbucher, great to be here! Looks like CLA just cleared.

@corona10 corona10 requested a review from vstinner November 20, 2019 18:04
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner is proper core developers to review this PR.
Can you please take a look at it? This is a very simple fix. :)

@miss-islington
Copy link
Contributor

Thanks @alexchandel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @alexchandel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @alexchandel and @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4e205b74f91400c0e6810e79370a99e29a28d599 3.7

@miss-islington
Copy link
Contributor

Sorry @alexchandel and @vstinner, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4e205b74f91400c0e6810e79370a99e29a28d599 3.8

@vstinner
Copy link
Member

I merged the PR, thanks.

But the automated backport to 3.7 and 3.8 failed. @alexchandel: Do you want to try to backport the change?

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
setattrofunc returns `int`, not `PyObject *`.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
setattrofunc returns `int`, not `PyObject *`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants