-
-
Notifications
You must be signed in to change notification settings - Fork 32k
[typo] fix quoted signature of setattrofunc #17251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setattrofunc returns `int`, not `PyObject *`.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Thanks for your time @alexchandel, and welcome to CPython! 😎 I assume that you've seen the bot's message about the CLA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! This looks good.
Thank you @brandtbucher, great to be here! Looks like CLA just cleared. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vstinner is proper core developers to review this PR.
Can you please take a look at it? This is a very simple fix. :)
Thanks @alexchandel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Thanks @alexchandel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, @alexchandel and @vstinner, I could not cleanly backport this to |
Sorry @alexchandel and @vstinner, I had trouble checking out the |
I merged the PR, thanks. But the automated backport to 3.7 and 3.8 failed. @alexchandel: Do you want to try to backport the change? |
setattrofunc returns `int`, not `PyObject *`.
setattrofunc returns `int`, not `PyObject *`.
setattrofunc
returnsint
, notPyObject *
.