bpo-39184: Add audit events to command execution functions in os and pty modules #17824
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
gousaiyang
requested review from
1st1,
asvetlov,
ethanfurman and
terryjreedy
as code owners
terryjreedy
requested review from
zooba
and removed request for
1st1,
asvetlov,
ethanfurman and
terryjreedy
|
I was about to close this and tell you to start over with a new PR, but you seem to have corrected it. In the future, do not hit the green [Make Pull Request] button unless the list of commits only has your commits and not those of others. Also, fix the list of suggested reviewers when needed. |
|
Sorry about this, the review request was automatically triggered by the system. I messed up with this branch (should not fetch changes by others) and fixed it by force push. |
|
Thanks! These look great! |
|
Thanks @gousaiyang for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry @gousaiyang and @zooba, I had trouble checking out the |
|
Thanks @gousaiyang for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
…pty modules (pythonGH-17824) (cherry picked from commit 95f6001) Co-authored-by: Saiyang Gou <[email protected]>
|
GH-18353 is a backport of this pull request to the 3.8 branch. |
…pty modules (GH-17824) (cherry picked from commit 95f6001) Co-authored-by: Saiyang Gou <[email protected]>
Add audit events to the following functions:
https://bugs.python.org/issue39184
https://bugs.python.org/issue39184