Skip to content

[3.8] bpo-39390 shutil: fix argument types for ignore callback (GH-18122). #18168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

[3.8] bpo-39390 shutil: fix argument types for ignore callback (GH-18122). #18168

merged 1 commit into from
Jan 27, 2020

Conversation

mbarkhau
Copy link
Contributor

@mbarkhau mbarkhau commented Jan 24, 2020 •
edited by bedevere-bot
Loading

(cherry picked from commit 8870433)

Co-authored-by: mbarkhau [email protected]

https://bugs.python.org/issue39390

@bedevere-bot bedevere-bot mentioned this pull request Jan 24, 2020
Merged
@mbarkhau mbarkhau requested a review from giampaolo January 24, 2020 16:03
@giampaolo
Copy link
Contributor

Since this is a regression, I think it deserves an entry at the bottom of Docs/whatsnew:

Notable changes in Python 3.8.2
===============================

Fixed a regression with the `ignore` callback of :func:`shutil.copytree`.
The argument types are now str and List[str] again.

@mbarkhau
Copy link
Contributor Author

Sorry, I missed your comment, will have a look at this later today.

@mbarkhau mbarkhau force-pushed the backport-8870433-3.8 branch from 778ba9c to 4c7cd9b Compare January 27, 2020 19:46
@mbarkhau mbarkhau force-pushed the backport-8870433-3.8 branch from 4c7cd9b to e08eb83 Compare January 27, 2020 19:58
@giampaolo giampaolo merged commit cf9d005 into python:3.8 Jan 27, 2020
@giampaolo
Copy link
Contributor

Merged, thanks.

@mbarkhau mbarkhau deleted the backport-8870433-3.8 branch January 28, 2020 06:49
@mbarkhau
Copy link
Contributor Author

And thank you for the hand holding ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giampaolo giampaolo Awaiting requested review from giampaolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbarkhau @giampaolo @the-knights-who-say-ni @bedevere-bot