Skip to content

bpo-39663: IDLE: Add additional tests for pyparse #18536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 18, 2020
Merged

bpo-39663: IDLE: Add additional tests for pyparse #18536

merged 4 commits into from
Feb 18, 2020

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Feb 17, 2020 •
edited by bedevere-bot
Loading

Add test cases when find_good_parse_start would return 0 instead of None.

https://bugs.python.org/issue39663

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Feb 17, 2020
@csabella
Copy link
Contributor Author

Test failure is unrelated to this change.

@python python deleted a comment from codecov bot Feb 18, 2020
terryjreedy
terryjreedy reviewed Feb 18, 2020
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will factor out "is_char_in_string=lambda index: False" and add news items and when CI passes, merge and backport.

@terryjreedy terryjreedy merged commit ffda25f into python:master Feb 18, 2020
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 18, 2020
@csabella @miss-islington
bpo-39663: IDLE: Add additional tests for pyparse (pythonGH-18536)
acda9dc 
Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <[email protected]>
@bedevere-bot
Copy link

GH-18541 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-18542 is a backport of this pull request to the 3.8 branch.

@terryjreedy
Copy link
Member

The unrelated macOS failure occurred again, but success seems to not currently be required.

miss-islington added a commit that referenced this pull request Feb 18, 2020
@miss-islington @csabella
bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)
fde0041 
Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <[email protected]>
miss-islington added a commit that referenced this pull request Feb 18, 2020
@miss-islington @csabella
bpo-39663: IDLE: Add additional tests for pyparse (GH-18536)
7fd752c 
Test when find_good_parse_start should return 0.

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit ffda25f)

Co-authored-by: Cheryl Sabella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csabella @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni