Skip to content

bpo-29298: Fix crash for required subparsers in argparse #18564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

bpo-29298: Fix crash for required subparsers in argparse #18564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b64faa6
Fix crash for required subparsers in argparse
BenSokol Feb 19, 2020
b5b458b
Create 2020-02-20-01-53-01.bpo-29298.laIn2S.rst
BenSokol Feb 20, 2020
3b4e42b
Update Misc/NEWS.d/next/Library/2020-02-20-01-53-01.bpo-29298.laIn2S.rst
BenSokol Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,8 @@ def _get_action_name(argument):
return argument.metavar
elif argument.dest not in (None, SUPPRESS):
return argument.dest
elif argument.choices not in (None, SUPPRESS):
return "{" + ','.join(argument.choices.keys()) + "}"
else:
return None

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2020-02-20-01-53-01.bpo-29298.laIn2S.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix crash in :mod:`argparse` when using subparsers and its required attribute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creash means segfault, not unhandled exception.

is set to True.