Skip to content

Valgrind no longer supports --db-attach=yes. #18568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Valgrind no longer supports --db-attach=yes. #18568

merged 1 commit into from
Feb 20, 2020

Conversation

skrah
Copy link
Contributor

@skrah skrah commented Feb 20, 2020

Small change that would have taken one minute with the previous mercurial setup. Now:

  • Try to commit directly, commit is refused.

  • Update CPython clone.

  • Try to login to GitHub, login is refused because of device "verification".

  • Fetch Email that contains a "verification" code.

  • Enter the code.

  • Open pull request.

  • Wait for GitHub buildbots (30 min).

  • Merge.

  • Look at Python buildbots.

@skrah
Copy link
Contributor Author

skrah commented Feb 20, 2020

That was not all. Additionally:

  • Set SkipIssue.

  • Set SkipNews.

@skrah skrah removed the request for review from rhettinger February 20, 2020 13:22
@skrah skrah self-assigned this Feb 20, 2020
@skrah skrah merged commit c0cb8be into python:master Feb 20, 2020
@bedevere-bot
Copy link

@skrah: Please replace # with GH- in the commit message next time. Thanks!

sthagen added a commit to sthagen/python-cpython that referenced this pull request Feb 20, 2020
Valgrind no longer supports --db-attach=yes. (python#18568)
@miss-islington
Copy link
Contributor

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2020
(cherry picked from commit c0cb8be)

Co-authored-by: Stefan Krah <[email protected]>
@bedevere-bot
Copy link

GH-18576 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2020
(cherry picked from commit c0cb8be)

Co-authored-by: Stefan Krah <[email protected]>
@bedevere-bot
Copy link

GH-18577 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2020
(cherry picked from commit c0cb8be)

Co-authored-by: Stefan Krah <[email protected]>
@bedevere-bot
Copy link

GH-18578 is a backport of this pull request to the 3.7 branch.

skrah added a commit that referenced this pull request Feb 20, 2020
(cherry picked from commit c0cb8be)

Co-authored-by: Stefan Krah <[email protected]>

Co-authored-by: Stefan Krah <[email protected]>
skrah added a commit that referenced this pull request Feb 20, 2020
(cherry picked from commit c0cb8be)

Co-authored-by: Stefan Krah <[email protected]>

Co-authored-by: Stefan Krah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants