Skip to content

bpo-39576: Prevent memory error for overly optimistic precisions #18581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2020
Merged

bpo-39576: Prevent memory error for overly optimistic precisions #18581

merged 3 commits into from
Feb 21, 2020

Conversation

skrah
Copy link
Contributor

@skrah skrah commented Feb 20, 2020

…nt_memory_error_for_overly_optimistic_precisions
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #18581 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18581      +/-   ##
==========================================
- Coverage   82.11%   82.07%   -0.05%     
==========================================
  Files        1956     1955       -1     
  Lines      589357   584055    -5302     
  Branches    44458    44458              
==========================================
- Hits       483953   479340    -4613     
+ Misses      95756    95090     -666     
+ Partials     9648     9625      -23     
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
... and 434 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c444d0...f7d108b. Read the comment docs.

@miss-islington
Copy link
Contributor

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @skrah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-18584 is a backport of this pull request to the 3.8 branch.

@skrah skrah deleted the prevent_memory_error_for_overly_optimistic_precisions branch February 21, 2020 00:54
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2020
@bedevere-bot
Copy link

GH-18585 is a backport of this pull request to the 3.7 branch.

skrah pushed a commit that referenced this pull request Feb 21, 2020
skrah pushed a commit that referenced this pull request Feb 21, 2020
yan12125 added a commit to archlinuxcn/repo that referenced this pull request Feb 22, 2020
The latest test failure is test_decimal. [1] attempts to fix it but
apparently it does not work with extra/mpdecimal in Arch Linux. I don't
have time to investigate it, so I just ignore it. I also ignore future
possible test failures - keep tests green is difficult :/

[1] python/cpython#18581
skrah added a commit that referenced this pull request Jun 8, 2020
skrah added a commit that referenced this pull request Jun 8, 2020
dundee pushed a commit to dundee/pkgbuilds that referenced this pull request Feb 13, 2022
* Split tests
* Mirror Fedora changes to improve performance

ignore test failures

The latest test failure is test_decimal. [1] attempts to fix it but
apparently it does not work with extra/mpdecimal in Arch Linux. I don't
have time to investigate it, so I just ignore it. I also ignore future
possible test failures - keep tests green is difficult :/

[1] python/cpython#18581
dundee pushed a commit to dundee/pkgbuilds that referenced this pull request Sep 6, 2022
* Split tests
* Mirror Fedora changes to improve performance

ignore test failures

The latest test failure is test_decimal. [1] attempts to fix it but
apparently it does not work with extra/mpdecimal in Arch Linux. I don't
have time to investigate it, so I just ignore it. I also ignore future
possible test failures - keep tests green is difficult :/

[1] python/cpython#18581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants