Skip to content

bpo-40626: Support HDF5 in mimetypes #20042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2020
Merged

bpo-40626: Support HDF5 in mimetypes #20042

merged 3 commits into from
Jun 11, 2020

Conversation

schwabm
Copy link
Contributor

@schwabm schwabm commented May 11, 2020 •
edited by bedevere-bot
Loading

Could you update the types to include the newer version of hdf... hdf5 with .h5 file extension?
See 'Recommendations' section for mime types from the HDF group here: https://www.hdfgroup.org/2018/06/citations-for-hdf-data-and-software/

https://bugs.python.org/issue40626

@schwabm
Update mimetypes.py
8d96055 
Could you update the types to include the newer version of hdf... hdf5 with .h5 file extension?
See 'Recommendations' section for mime types from the HDF group here:  https://www.hdfgroup.org/2018/06/citations-for-hdf-data-and-software/
@schwabm schwabm requested a review from a team as a code owner May 11, 2020 23:13
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@schwabm

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Member

This would require an issue in https://bugs.python.org .

@schwabm
Copy link
Contributor Author

schwabm commented May 14, 2020

This would require an issue in https://bugs.python.org .

created an issue.

@schwabm
Copy link
Contributor Author

schwabm commented May 18, 2020

Any idea if or when this might finish review and be merged?

remilapeyre
remilapeyre suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @schwbm, the change looks correct, thanks for your contribution!

Can you change the title of this Pull Request to "bpo-40626: Support HDF5 in mimetypes"?

A core developer will review your PR and will either merge it or ask for some changes. This can take some time as there is a lot of work going on in Python but they will get there. There is not need for merging quickly anyway, it only needs to be done before the next release of Python.

@remilapeyre
Copy link
Contributor

This change will also require a NEWS entry (https://devguide.python.org/committing/#what-s-new-and-news-entries), you can add one by using https://blurb-it.herokuapp.com/

@schwabm schwabm changed the title Update mimetypes.py bpo-40626: Support HDF5 in mimetypes May 18, 2020
@schwabm
Copy link
Contributor Author

schwabm commented May 18, 2020 via email •
edited by bedevere-bot
Loading

remilapeyre
remilapeyre approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@akuchling akuchling self-assigned this Jun 11, 2020
@akuchling akuchling merged commit 60c2a81 into python:master Jun 11, 2020
@miss-islington
Copy link
Contributor

Thanks @schwabm for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-20818 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2020
@schwabm @miss-islington
bpo-40626: Support HDF5 in mimetypes (pythonGH-20042)
f7cb420 
Add hdf5 with .h5 file extension

See 'Recommendations' section for mime types from the HDF group:  https://www.hdfgroup.org/2018/06/citations-for-hdf-data-and-software/

Patch by Mark Schwab.
(cherry picked from commit 60c2a81)

Co-authored-by: MARK SCHWAB <[email protected]>
miss-islington added a commit that referenced this pull request Jun 11, 2020
@miss-islington @schwabm
bpo-40626: Support HDF5 in mimetypes (GH-20042)
a3d6d23 
Add hdf5 with .h5 file extension

See 'Recommendations' section for mime types from the HDF group:  https://www.hdfgroup.org/2018/06/citations-for-hdf-data-and-software/

Patch by Mark Schwab.
(cherry picked from commit 60c2a81)

Co-authored-by: MARK SCHWAB <[email protected]>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@schwabm @arun-mani-j
bpo-40626: Support HDF5 in mimetypes (pythonGH-20042)
cba0a01 
Add hdf5 with .h5 file extension

See 'Recommendations' section for mime types from the HDF group:  https://www.hdfgroup.org/2018/06/citations-for-hdf-data-and-software/

Patch by Mark Schwab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuchling akuchling akuchling approved these changes

@remilapeyre remilapeyre remilapeyre approved these changes

Assignees

@akuchling akuchling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@schwabm @the-knights-who-say-ni @tirkarthi @remilapeyre @miss-islington @bedevere-bot @akuchling