Skip to content

bpo-40677: Define IO_REPARSE_TAG_APPEXECLINK for old Windows SDK #20206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2020

Conversation

gongminmin
Copy link
Contributor

@gongminmin gongminmin commented May 19, 2020

Manually define IO_REPARSE_TAG_APPEXECLINK in case some old Windows SDK doesn't have it.

https://bugs.python.org/issue40677

@zooba zooba added needs backport to 3.8 needs backport to 3.9 only security fixes OS-windows type-bug An unexpected behavior, bug, or error labels May 19, 2020
@zooba zooba merged commit 711f9e1 into python:master May 19, 2020
@miss-islington
Copy link
Contributor

Thanks @gongminmin for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2020
This allows building with older versions of the Windows SDK where the value is not defined.
(cherry picked from commit 711f9e1)

Co-authored-by: Minmin Gong <[email protected]>
@bedevere-bot
Copy link

GH-20217 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 19, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2020
This allows building with older versions of the Windows SDK where the value is not defined.
(cherry picked from commit 711f9e1)

Co-authored-by: Minmin Gong <[email protected]>
@bedevere-bot
Copy link

GH-20218 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request May 19, 2020
This allows building with older versions of the Windows SDK where the value is not defined.
(cherry picked from commit 711f9e1)

Co-authored-by: Minmin Gong <[email protected]>
miss-islington added a commit that referenced this pull request May 19, 2020
This allows building with older versions of the Windows SDK where the value is not defined.
(cherry picked from commit 711f9e1)

Co-authored-by: Minmin Gong <[email protected]>
@gongminmin gongminmin deleted the FixIO_REPARSE_TAG_APPEXECLINK branch May 20, 2020 02:01
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
This allows building with older versions of the Windows SDK where the value is not defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants