Skip to content

bpo-40927: Fix test_binhex when run twice #20764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020
Merged

bpo-40927: Fix test_binhex when run twice #20764

merged 1 commit into from
Jun 10, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 9, 2020

test_binhex now uses import_fresh_module() to ensure that it raises
DeprecationWarning each time.

https://bugs.python.org/issue40927

test_binhex now uses import_fresh_module() to ensure that it raises
DeprecationWarning each time.
@vstinner
Copy link
Member Author

vstinner commented Jun 9, 2020

Another fix: PR #20758.

@vstinner vstinner merged commit 9c24e2e into python:master Jun 10, 2020
@vstinner vstinner deleted the test_binhex branch June 10, 2020 17:54
@vstinner vstinner added the needs backport to 3.9 only security fixes label Jun 10, 2020
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @vstinner, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9c24e2e4c10705d95258558348417a28007dac66 3.9

@bedevere-bot
Copy link

GH-20789 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 10, 2020
vstinner added a commit that referenced this pull request Jun 10, 2020
test_binhex now uses import_fresh_module() to ensure that it raises
DeprecationWarning each time.

(cherry picked from commit 9c24e2e)
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
test_binhex now uses import_fresh_module() to ensure that it raises
DeprecationWarning each time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants