Skip to content

gh-83365: Fix incorrect return value in msvcrt_get_osfhandle_impl #21322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-83365: Fix incorrect return value in msvcrt_get_osfhandle_impl #21322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f5fcc4
bpo-39184: Fix incorrect return value in `msvcrt_get_osfhandle_impl`
gousaiyang Jul 4, 2020
b2d85a6
Merge branch 'main' into bpo-39184-fix-msvcrt_get_osfhandle
kumaraditya303 Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PC/msvcrtmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ msvcrt_get_osfhandle_impl(PyObject *module, int fd)
/*[clinic end generated code: output=aca01dfe24637374 input=5fcfde9b17136aa2]*/
{
if (PySys_Audit("msvcrt.get_osfhandle", "(i)", fd) < 0) {
return NULL;
return -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return -1;
return (void*)-1;

}

return _Py_get_osfhandle(fd);
Expand Down