-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-86155: Fix htmlparser "unclosed script tag causes data loss" #22658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When calling .close() the htmlparser should flush all remaining content, even when that content is in an unclosed script or style tag.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This PR is stale because it has been open for 30 days with no activity. |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
@ezio-melotti (as an html expert) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Misc/NEWS.d/next/Library/2023-02-13-21-41-34.gh-issue-86155.ppIGSC.rst
Outdated
Show resolved
Hide resolved
Thanks @waylan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…TMLParser (pythonGH-22658) When calling .close() the HTMLParser should flush all remaining content, even when that content is in an unclosed script or style tag. (cherry picked from commit 53383e9) Co-authored-by: Waylan Limberg <[email protected]>
…TMLParser (pythonGH-22658) When calling .close() the HTMLParser should flush all remaining content, even when that content is in an unclosed script or style tag. (cherry picked from commit 53383e9) Co-authored-by: Waylan Limberg <[email protected]>
GH-133844 is a backport of this pull request to the 3.14 branch. |
GH-133845 is a backport of this pull request to the 3.13 branch. |
…HTMLParser (GH-22658) (GH-133845) When calling .close() the HTMLParser should flush all remaining content, even when that content is in an unclosed script or style tag. (cherry picked from commit 53383e9) Co-authored-by: Waylan Limberg <[email protected]>
…HTMLParser (GH-22658) (GH-133844) When calling .close() the HTMLParser should flush all remaining content, even when that content is in an unclosed script or style tag. (cherry picked from commit 53383e9) Co-authored-by: Waylan Limberg <[email protected]>
When calling .close() the htmlparser should flush all remaining content,
even when that content is in an unclosed script or style tag.
https://bugs.python.org/issue41989