Skip to content

[WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements #24492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

[WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements #24492

wants to merge 15 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 9, 2021 •
edited
Loading

Fixes #81040

@erlend-aasland
Copy link
Contributor Author

Cherry-picked from #13216 and rebased onto master.

cc. @berkerpeksag @coleifer @serhiy-storchaka

@erlend-aasland erlend-aasland marked this pull request as draft March 2, 2021 09:15
@github-actions
Copy link

github-actions bot commented Apr 2, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 2, 2021
@erlend-aasland erlend-aasland changed the title bpo-36859: use sqlite3_stmt_readonly() to detect DML statements [WIP] bpo-36859: use sqlite3_stmt_readonly() to detect DML statements May 18, 2021
@erlend-aasland erlend-aasland force-pushed the bpo-36859 branch 3 times, most recently from ba8d1e6 to dce7ada Compare June 5, 2021 21:27
MaxwellDupre
MaxwellDupre suggested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 18 tests in 0.481s
OK
Other Sqlite tests also passed. Looks ok.
Need to add to Docs, not just NEWS otherwise users will not be aware.

@erlend-aasland erlend-aasland changed the title [WIP] bpo-36859: use sqlite3_stmt_readonly() to detect DML statements [WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements Apr 10, 2022
@coleifer coleifer mannequin mentioned this pull request May 16, 2022
Closed
@erlend-aasland
Copy link
Contributor Author

I'm not sure this is the correct way to address to the problems in the linked issue. Closing.

@erlend-aasland erlend-aasland deleted the bpo-36859 branch June 27, 2022 08:01
@coleifer coleifer mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre requested changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3 dml statement detection does not account for CTEs
6 participants
@erlend-aasland @MaxwellDupre @the-knights-who-say-ni @bedevere-bot @coleifer @berkerpeksag