Skip to content

Doc: io: Remove "In-memory streams" section #24927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

methane
Copy link
Member

@methane methane commented Mar 18, 2021

This section looks be misplaced. It was written in b530e14.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overview describes the three separate classes of IO: raw, buffered binary, and text. "In-memory streams" are not a fourth kind of IO, so they don't belong in the overview.

We may want to move them into the "Class hierarchy" section however.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@methane
Copy link
Member Author

methane commented Mar 21, 2021

BytesIO is in "Buffered Streams" section (because it inherits BufferedIOBase), and StringIO is in "Text I/O" section.

May I just remove this "In-memory streams" section?

@methane methane changed the title Doc: io: Move In-memory streams section into overview section. Doc: io: Remove "In-memory streams" section Mar 21, 2021
@methane methane merged commit b045cda into python:master Mar 25, 2021
@methane methane deleted the doc-io branch March 25, 2021 07:23
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-25017 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 25, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2021
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <[email protected]>
@bedevere-bot
Copy link

GH-25018 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2021
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <[email protected]>
methane added a commit that referenced this pull request Apr 1, 2021
(cherry picked from commit b045cda)
Co-authored-by: Inada Naoki <[email protected]>
methane added a commit that referenced this pull request Apr 1, 2021
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants