Skip to content

bpo-43591: Fix error location in interactive mode for errors at the end of the line #24973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Lib/test/test_cmd_line.py
Original file line number Diff line number Diff line change
Expand Up @@ -851,13 +851,19 @@ def test_sys_flags_not_set(self):
)

class SyntaxErrorTests(unittest.TestCase):
def test_tokenizer_error_with_stdin(self):
proc = subprocess.run([sys.executable, "-"], input = b"(1+2+3",
def check_string(self, code):
proc = subprocess.run([sys.executable, "-"], input=code,
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
self.assertNotEqual(proc.returncode, 0)
self.assertNotEqual(proc.stderr, None)
self.assertIn(b"\nSyntaxError", proc.stderr)

def test_tokenizer_error_with_stdin(self):
self.check_string(b"(1+2+3")

def test_decoding_error_at_the_end_of_the_line(self):
self.check_string(b"'\u1f'")

def test_main():
support.run_unittest(CmdLineTest, IgnoreEnvironmentTest, SyntaxErrorTests)
support.reap_children()
Expand Down
14 changes: 9 additions & 5 deletions Parser/pegen.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,11 @@ byte_offset_to_character_offset(PyObject *line, Py_ssize_t col_offset)
if (!str) {
return 0;
}
assert(col_offset >= 0 && (unsigned long)col_offset <= strlen(str));
Py_ssize_t len = strlen(str);
if (col_offset > len) {
col_offset = len;
}
assert(col_offset >= 0);
PyObject *text = PyUnicode_DecodeUTF8(str, col_offset, "replace");
if (!text) {
return 0;
Expand Down Expand Up @@ -392,10 +396,10 @@ _PyPegen_raise_error(Parser *p, PyObject *errtype, const char *errmsg, ...)
static PyObject *
get_error_line(Parser *p, Py_ssize_t lineno)
{
/* If p->tok->fp == NULL, then we're parsing from a string, which means that
the whole source is stored in p->tok->str. If not, then we're parsing
from the REPL, so the source lines of the current (multi-line) statement
are stored in p->tok->stdin_content */
/* If the file descriptor is interactive, the source lines of the current
* (multi-line) statement are stored in p->tok->interactive_src_start.
* If not, we're parsing from a string, which means that the whole source
* is stored in p->tok->str. */
assert(p->tok->fp == NULL || p->tok->fp == stdin);

char *cur_line = p->tok->fp_interactive ? p->tok->interactive_src_start : p->tok->str;
Expand Down