Skip to content

bpo-41064: Improve syntax error for invalid usage of '**' in f-strings #25006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

bpo-41064: Improve syntax error for invalid usage of '**' in f-strings #25006

merged 1 commit into from
Mar 24, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 24, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou as a code owner March 24, 2021 00:32
@terryjreedy
Copy link
Member

terryjreedy commented Mar 24, 2021 •
edited
Loading

Pipelines test failure is random test_asyncio failure that can be ignored.

FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)

Traceback (most recent call last):
File "D:\a\1\s\lib\test\test_asyncio\test_sendfile.py", line 458, in test_sendfile_close_peer_in_the_middle_of_receiving
self.run_loop(
AssertionError: ConnectionError not raised

@terryjreedy
Copy link
Member

Patch works for me on Win 10 with no new test suite failures.

@pablogsal pablogsal merged commit 8efad61 into python:master Mar 24, 2021
@pablogsal pablogsal deleted the bpo-41064 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @terryjreedy @lysnikolaou @the-knights-who-say-ni @bedevere-bot